feat(engine): make metrics in ui more readable#8883
Merged
sipsma merged 1 commit intoNov 8, 2024
Merged
Conversation
Signed-off-by: Connor Braa <connor@dagger.io>
Contributor
|
Nice!
Oh interesting, I think those being present in the cgroup might be dependent on kernel config, so possible you aren't getting them. I'll pull this locally and give it a quick check. |
sipsma
approved these changes
Nov 8, 2024
Contributor
sipsma
left a comment
sipsma
left a comment
There was a problem hiding this comment.
any suggestions on how to manually test the pressure duration printing? I never have these print on dagger call check.
Oh interesting, I think those being present in the cgroup might be dependent on kernel config, so possible you aren't getting them. I'll pull this locally and give it a quick check.
Tried it out locally and looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR makes the tui print human-readable byte and duration values.
any suggestions on how to manually test the pressure duration printing? I never have these print on
dagger call check.bytes, however, are confirmed working and looking good:
exec sh -c git checkout -q $(git rev-parse HEAD) 0.4s | Disk Read Bytes: 45 MB | Disk Write Bytes: 12 kB