chore: bump internal tooling to v0.14.0#8905
Merged
Merged
Conversation
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
- Rename `DEngine` to `DaggerEngine` - Fix `module_test` to use the correct core function name Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Contributor
|
jedevc
approved these changes
Nov 12, 2024
Contributor
jedevc
left a comment
jedevc
left a comment
There was a problem hiding this comment.
LGTM as-is - can merge now, and we can do follow-ups later 🎉
Contributor
Pain 😢 |
TIL: `/` only applies to git (not GitHub) The semantics are: if a new PR gets created which changes the `.changes/.next` file, deploy a preview environment. These PRs **must** be opened from branches that belog to the upstream repository - `dagger/dagger` - otherwise the secret will not be available and therefore the `dagger/dagger.io` PR cannot be created due to insufficient permissions. I have updated `RELEASING.md` to reflect this. Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
gerhard
approved these changes
Nov 12, 2024
Contributor
gerhard
left a comment
gerhard
left a comment
There was a problem hiding this comment.
I pushed the fix for daggerverse-preview & added extra details to RELEASING.md.
CI runners are ready for this, all looking good, merging 🧑🚒
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just autogenerated stuff here.
FTR, hit lots of things big and small but will split them out to follow ups so this isn't blocked too long:
.changes/.nextis in wrong order (shouldbe included in a commit that's pushed)