Skip to content

docs: Update images and code in feature pages#9064

Merged
vikram-dagger merged 2 commits into
dagger:mainfrom
vikram-dagger:feature-pages-update
Jan 13, 2025
Merged

docs: Update images and code in feature pages#9064
vikram-dagger merged 2 commits into
dagger:mainfrom
vikram-dagger:feature-pages-update

Conversation

@vikram-dagger
Copy link
Copy Markdown
Contributor

@vikram-dagger vikram-dagger commented Nov 27, 2024

This commit updates the screen recording GIFs for the new TUI, and also fixes some Go code snippets in the feature pages

@vikram-dagger vikram-dagger requested a review from a team as a code owner November 27, 2024 18:24
@levlaz
Copy link
Copy Markdown
Contributor

levlaz commented Nov 27, 2024

Overall this looks good, but I tested a few of these examples and it seems the new examples here take 3x longer than the old ones, is this something specific to your system or are you noticing this trend @vikram-dagger?

On my end running the same build example takes about ~6 seconds vs the 30 I see here.

@shykes
Copy link
Copy Markdown
Contributor

shykes commented Nov 27, 2024

Same comment, it's important that examples appear snappy.

@vikram-dagger
Copy link
Copy Markdown
Contributor Author

Overall this looks good, but I tested a few of these examples and it seems the new examples here take 3x longer than the old ones, is this something specific to your system or are you noticing this trend @vikram-dagger?

This is on an EC2 server, same size as the one before. I also sped up the recording 2-3x.

On my end running the same build example takes about ~6 seconds vs the 30 I see here.

Is this with a warm cache?

I'll try redoing them on a higher-spec server now.

@vikram-dagger
Copy link
Copy Markdown
Contributor Author

vikram-dagger commented Nov 28, 2024

Overall this looks good, but I tested a few of these examples and it seems the new examples here take 3x longer than the old ones, is this something specific to your system or are you noticing this trend @vikram-dagger?

Updated now recording off a higher-spec server. Builds are faster but it was still slow to watch at normal speed, so I have sped up the frames 2x. Let me know if better or if further changes are needed.

@mircubed
Copy link
Copy Markdown
Contributor

mircubed commented Dec 4, 2024

@shykes @levlaz blocking question from @vikram-dagger for this PR related to 0.15 launch:

Are these recordings still too slow?

If yes, should we re-record these now with a more powerful server or should we wait until 0.15 to re-record? We are unsure how much the TUI has changed for these commands between 0.14 and 0.15.

Vikram Vaswani added 2 commits December 17, 2024 17:34
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 5, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Copy Markdown
Contributor

This PR was closed because it has been stalled for 7 days with no activity.

Copy link
Copy Markdown
Contributor

@gerhard gerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9373 was created since a user mentioned incorrect examples.

I'm approving this so that we fix the examples, we can improve the speed as a follow-up. It's better for them to be correct than fast.

Copy link
Copy Markdown
Contributor

@gerhard gerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vikram-dagger vikram-dagger merged commit b6f1aaf into dagger:main Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants