fix duration scrubber for golden tests#9464
Merged
Merged
Conversation
The previous version was able to catch things like:
- 1m2.345s
- 12.34s
But wasn't able to catch:
- 1m23s
But it looks like it happens, sometimes:
+++ actual
@@ -11,7 +11,7 @@
│ ✔ starting session X.Xs
-✔ load module X.Xs
+✔ load module 1m13s
│ ✔ finding module configuration X.Xs
-│ ✔ initializing module X.Xs
+│ ✔ initializing module 1m12s
│ ✔ inspecting module metadata X.Xs
│ ✔ loading type definitions X.X
For instance: https://v3.dagger.cloud/dagger/traces/d3cd71a1531096b0071621d896b3ebe6?span=f3e3b1f9b2b1f4aa&logs#f3e3b1f9b2b1f4aa
Signed-off-by: Yves Brissaud <gh@lgtd.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version was able to catch things like:
1m2.345s12.34sBut wasn't able to catch:
1m23sBut it looks like it happens, sometimes:
For instance: https://v3.dagger.cloud/dagger/traces/d3cd71a1531096b0071621d896b3ebe6?span=f3e3b1f9b2b1f4aa&logs#f3e3b1f9b2b1f4aa