Skip to content

Revert "PHP: Ensure up to date dependencies of the generated code"#9692

Merged
jedevc merged 1 commit into
dagger:mainfrom
jedevc:revert-fix-composer-lock
Feb 24, 2025
Merged

Revert "PHP: Ensure up to date dependencies of the generated code"#9692
jedevc merged 1 commit into
dagger:mainfrom
jedevc:revert-fix-composer-lock

Conversation

@jedevc
Copy link
Copy Markdown
Contributor

@jedevc jedevc commented Feb 24, 2025

This reverts #9625 - looks like the PHP tests have started failing after it, not sure why.

cc @carnage @charjr

Example failure: https://v3.dagger.cloud/dagger/traces/1e0e5e64a1c90d597a534d6e8a6faf82?span=1f0ea2d68e44a4e2&logs

The tests that are failing:

t.Run("from upstream", func(ctx context.Context, t *testctx.T) {
c := connect(ctx, t)
modGen := c.Container().From(golangImage).
WithMountedFile(testCLIBinPath, daggerCliFile(t, c)).
WithWorkdir("/work").
With(daggerExec("init", "--name=bare", "--sdk=github.com/dagger/dagger/sdk/php"))
out, err := modGen.
With(daggerQuery(`{bare{containerEcho(stringArg:"hello"){stdout}}}`)).
Stdout(ctx)
require.NoError(t, err)
require.JSONEq(t, `{"bare":{"containerEcho":{"stdout":"hello\n"}}}`, out)
})

These only started failing on main because these tests fetch the version of the PHP SDK from main. While these checks are somewhat important, we should probably have a test for the commit - similar to how it's done for TestJava.

This reverts commit 09516b4.

Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc requested a review from a team as a code owner February 24, 2025 10:57
@carnage
Copy link
Copy Markdown
Contributor

carnage commented Feb 24, 2025

@jedevc jedevc merged commit b88f414 into dagger:main Feb 24, 2025
@jedevc jedevc deleted the revert-fix-composer-lock branch February 24, 2025 11:28
eunomie added a commit to lgtdio/dagger that referenced this pull request Feb 24, 2025
* main:
  sdk/java: constructors (dagger#9523)
  shell: run from root command (dagger#9631)
  Update "types" in package.json (dagger#9657)
  chore(deps): bump typedoc in /docs in the docs group (dagger#9689)
  feat: add `name` in Directory API (dagger#9617)
  Revert "PHP: Ensure up to date dependencies of the generated code" (dagger#9692)
  fix: add version compat check when parsing module config (dagger#9671)
  fix(sdk/java): dependencies to build should be outside of src (dagger#9686)
  reapply tsx bundling w/ fix for x-architecture builds (dagger#9652)
  fix(sdk/java): conflict on tests between last two merges (dagger#9677)

Signed-off-by: Yves Brissaud <gh@lgtd.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants