Revert "PHP: Ensure up to date dependencies of the generated code"#9692
Merged
Conversation
This reverts commit 09516b4. Signed-off-by: Justin Chadwell <me@jedevc.com>
Contributor
|
✅ |
charjr
approved these changes
Feb 24, 2025
eunomie
added a commit
to lgtdio/dagger
that referenced
this pull request
Feb 24, 2025
* main: sdk/java: constructors (dagger#9523) shell: run from root command (dagger#9631) Update "types" in package.json (dagger#9657) chore(deps): bump typedoc in /docs in the docs group (dagger#9689) feat: add `name` in Directory API (dagger#9617) Revert "PHP: Ensure up to date dependencies of the generated code" (dagger#9692) fix: add version compat check when parsing module config (dagger#9671) fix(sdk/java): dependencies to build should be outside of src (dagger#9686) reapply tsx bundling w/ fix for x-architecture builds (dagger#9652) fix(sdk/java): conflict on tests between last two merges (dagger#9677) Signed-off-by: Yves Brissaud <gh@lgtd.io>
This was referenced Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #9625 - looks like the PHP tests have started failing after it, not sure why.
cc @carnage @charjr
Example failure: https://v3.dagger.cloud/dagger/traces/1e0e5e64a1c90d597a534d6e8a6faf82?span=1f0ea2d68e44a4e2&logs
The tests that are failing:
dagger/core/integration/module_php_test.go
Lines 18 to 31 in bf712c4
These only started failing on
mainbecause these tests fetch the version of the PHP SDK from main. While these checks are somewhat important, we should probably have a test for the commit - similar to how it's done forTestJava.