Skip to content

test: PHP Scalar, List and Void signatures#9938

Merged
charjr merged 2 commits into
dagger:mainfrom
charjr:integration-test-arg-types
Mar 24, 2025
Merged

test: PHP Scalar, List and Void signatures#9938
charjr merged 2 commits into
dagger:mainfrom
charjr:integration-test-arg-types

Conversation

@charjr
Copy link
Copy Markdown
Contributor

@charjr charjr commented Mar 21, 2025

Adds integration tests requiring that the PHP SDK can handle method signatures of:

  • Scalar Kind
  • List Kind
  • Void Kind

Signed-off-by: John Charman <john.charman@imhotek.net>
@charjr charjr requested a review from jedevc March 21, 2025 15:46
@charjr charjr merged commit 6e72122 into dagger:main Mar 24, 2025
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to having it this way, but is there a reason to not have all this be one module, and have the module declare multiple types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants