Skip to content
This repository was archived by the owner on Nov 21, 2023. It is now read-only.

Update multibuild concurrency#7

Merged
jpadams merged 2 commits into
dagger:mainfrom
kpenfound:update_getting_started_concurrency
Nov 21, 2022
Merged

Update multibuild concurrency#7
jpadams merged 2 commits into
dagger:mainfrom
kpenfound:update_getting_started_concurrency

Conversation

@kpenfound
Copy link
Copy Markdown
Collaborator

Coded live in the community call

This starts by aligning the content with the getting-started guide, and then replacing the go errgroup concurrency with nothing to let buildkit handle the concurrency for us

Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Copy link
Copy Markdown
Contributor

@jpadams jpadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@jpadams jpadams merged commit 97ccd83 into dagger:main Nov 21, 2022
@dolanor
Copy link
Copy Markdown

dolanor commented Nov 25, 2022

https://discord.com/channels/707636530424053791/1037791976696840218/1045701987678818386
We should remove reference of errgroup in the getting started docs as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants