update on 2020/3/22 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow derived classes to have access to the protected variables and methods.
…to differentiate it from the other write()'s The others first write their 16-bit length before the data.
_payload_callback should be initialized or we have crash (in case no _GLIBCXX_FUNCTIONAL available)
Fix not initialized field
…intable Cut down on duplicated code for handling both JsonObject and JsonArray.
…hile we wait for an acknowledgment (in persistent session and QoS > 0)
Solve Issue #72
Fix: Library remains blocked and PUBCOMP packet
Make library name uniqe by adding username in parentheses
…S == 1 Also fix the OTA over MQTT example.
Users on other platforms should include <functional> before <PubSubClient.h> if they want the added C++ features with callbacks. Should I remove these lines and force all users to include the appropriate headers?
This gives a little extra type checking, at least with assignment.
Just continue the loop and see if available() or another read() fixes things?
Use C++ new/delete for all other dynamic allocation. Should I use std::vector instead? From a look on my system, it appears that std::vector is available on all ARM-based processors and ESP8266/ESP32. But not AVR. Is it safe to exclude AVR for this library?
Essentially the same thing in C++.
…than a simple uint8_t[4]
… types and functions
Client object is first, callback is set with a method.
Some of the uses in connect_spec require constructing our own custom Connect object.
…llow compilation outside of the Arduino env
…brary has no such define And sizes are 32-bit now. TODO: Will have to construct the 'publish' packets with the correct size when this max size is greater than 127 bytes.
MQTT packets can be up to 24MB in size.
MQTT/4 instead of MQIsdp/3
…e packet in Client's buffer Not tested!
A better way to encapsulate the state variables. Still untested!
…g length byte(s) This allows us to parse the small, simple packets e.g connack, ping, etc. They're only four bytes, smaller than the five byte minimum in _read_header(). _read_length() is reenterable, able to shift a single available byte and continue later.
…e message It returns nullptr instead of false.
…s for a response The second one returns a message pointer of the message that came back, thanks to _wait_for().
CONNACK doesn't necessarily mean the connection was successful.
Owner
Author
|
update on 2020/3/22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update on 2020/3/22