Skip to content

Remove partitions_def from ExecutableComponent - #30420

Merged
schrockn merged 1 commit into
masterfrom
schrockn/remove-partition-definition-for-now
Jun 3, 2025
Merged

schrockn merged 1 commit into
masterfrom
schrockn/remove-partition-definition-for-now

Conversation

@schrockn

@schrockn schrockn commented Jun 3, 2025 •

Copy link
Copy Markdown
Contributor

Summary & Motivation

In the spirit of only having one way of doing things, I'm going to pull partitions definition of the Executable Component, and rely on it in AssetSpec only. Worthy of discussion. If we do this we probably want some group assignment primitive as there are a few properties like this.

How I Tested These Changes

BK

@schrockn
schrockn changed the base branch from schrockn/add-pool-to-executable-component to graphite-base/30420 June 3, 2025 09:41
@schrockn
schrockn force-pushed the schrockn/remove-partition-definition-for-now branch from 4a0b5ba to f7464fe Compare June 3, 2025 09:41
@schrockn
schrockn force-pushed the graphite-base/30420 branch from 5b4122c to caaa7a3 Compare June 3, 2025 09:41
@schrockn
schrockn changed the base branch from graphite-base/30420 to schrockn/description-in-executable-component June 3, 2025 09:41
This was referenced Jun 3, 2025
@schrockn
schrockn requested review from alangenfeld and benpankow June 3, 2025 12:56
@schrockn
schrockn marked this pull request as ready for review June 3, 2025 12:56
@schrockn
schrockn force-pushed the schrockn/description-in-executable-component branch from caaa7a3 to 6cc8d33 Compare June 3, 2025 14:56
@schrockn
schrockn force-pushed the schrockn/remove-partition-definition-for-now branch 2 times, most recently from a4bbfe7 to 8f164b2 Compare June 3, 2025 15:31
@schrockn
schrockn force-pushed the schrockn/description-in-executable-component branch from 6cc8d33 to 3082360 Compare June 3, 2025 15:31
@schrockn
schrockn force-pushed the schrockn/remove-partition-definition-for-now branch from 8f164b2 to dc1a5ba Compare June 3, 2025 19:12
@schrockn
schrockn force-pushed the schrockn/description-in-executable-component branch from 3082360 to 46ff37e Compare June 3, 2025 19:12
@schrockn schrockn mentioned this pull request Jun 3, 2025
@schrockn
schrockn changed the base branch from schrockn/description-in-executable-component to graphite-base/30420 June 3, 2025 20:11
@schrockn
schrockn force-pushed the schrockn/remove-partition-definition-for-now branch from dc1a5ba to c87ac19 Compare June 3, 2025 20:16
@schrockn
schrockn force-pushed the graphite-base/30420 branch from 46ff37e to ebec7f0 Compare June 3, 2025 20:16
@graphite-app
graphite-app Bot changed the base branch from graphite-base/30420 to master June 3, 2025 20:17
@schrockn
schrockn force-pushed the schrockn/remove-partition-definition-for-now branch 2 times, most recently from abe788b to bda69ba Compare June 3, 2025 22:02

schrockn commented Jun 3, 2025 •

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jun 3, 10:27 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 3, 10:28 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 3, 10:29 PM UTC: @schrockn merged this pull request with Graphite.

@schrockn
schrockn force-pushed the schrockn/remove-partition-definition-for-now branch from bda69ba to f92cfdc Compare June 3, 2025 22:28
@schrockn
schrockn merged commit 2823f72 into master Jun 3, 2025
@schrockn
schrockn deleted the schrockn/remove-partition-definition-for-now branch June 3, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants