Repository navigation
Remove partitions_def from ExecutableComponent - #30420
Merged
Merged
Conversation
This was referenced Jun 3, 2025
Contributor
Author
schrockn
changed the base branch from
schrockn/add-pool-to-executable-component
to
graphite-base/30420
June 3, 2025 09:41
schrockn
force-pushed
the
schrockn/remove-partition-definition-for-now
branch
from
June 3, 2025 09:41
4a0b5ba to
f7464fe
Compare
schrockn
force-pushed
the
graphite-base/30420
branch
from
June 3, 2025 09:41
5b4122c to
caaa7a3
Compare
schrockn
changed the base branch from
graphite-base/30420
to
schrockn/description-in-executable-component
June 3, 2025 09:41
schrockn
marked this pull request as ready for review
June 3, 2025 12:56
This was referenced Jun 3, 2025
schrockn
force-pushed
the
schrockn/description-in-executable-component
branch
from
June 3, 2025 14:56
caaa7a3 to
6cc8d33
Compare
schrockn
force-pushed
the
schrockn/remove-partition-definition-for-now
branch
2 times, most recently
from
June 3, 2025 15:31
a4bbfe7 to
8f164b2
Compare
schrockn
force-pushed
the
schrockn/description-in-executable-component
branch
from
June 3, 2025 15:31
6cc8d33 to
3082360
Compare
alangenfeld
approved these changes
Jun 3, 2025
schrockn
force-pushed
the
schrockn/remove-partition-definition-for-now
branch
from
June 3, 2025 19:12
8f164b2 to
dc1a5ba
Compare
schrockn
force-pushed
the
schrockn/description-in-executable-component
branch
from
June 3, 2025 19:12
3082360 to
46ff37e
Compare
Merged
schrockn
changed the base branch from
schrockn/description-in-executable-component
to
graphite-base/30420
June 3, 2025 20:11
schrockn
force-pushed
the
schrockn/remove-partition-definition-for-now
branch
from
June 3, 2025 20:16
dc1a5ba to
c87ac19
Compare
schrockn
force-pushed
the
graphite-base/30420
branch
from
June 3, 2025 20:16
46ff37e to
ebec7f0
Compare
schrockn
force-pushed
the
schrockn/remove-partition-definition-for-now
branch
2 times, most recently
from
June 3, 2025 22:02
abe788b to
bda69ba
Compare
Contributor
Author
schrockn
force-pushed
the
schrockn/remove-partition-definition-for-now
branch
from
June 3, 2025 22:28
bda69ba to
f92cfdc
Compare
This was referenced Jun 5, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary & Motivation
In the spirit of only having one way of doing things, I'm going to pull partitions definition of the Executable Component, and rely on it in
AssetSpeconly. Worthy of discussion. If we do this we probably want some group assignment primitive as there are a few properties like this.How I Tested These Changes
BK