Fix docs checkouts on cross-repo Pull Requests#15116
Closed
PeterJCLaw wants to merge 2 commits intodagster-io:masterfrom
Closed
Fix docs checkouts on cross-repo Pull Requests#15116PeterJCLaw wants to merge 2 commits intodagster-io:masterfrom
PeterJCLaw wants to merge 2 commits intodagster-io:masterfrom
Conversation
Thus ensuring that changes to the build logic are suitably tested in CI and result in rebuilds when merged.
PeterJCLaw
force-pushed
the
fix-docs-ci-external-prs
branch
6 times, most recently
from
eea0526 to
7511e32
Compare
PeterJCLaw
changed the title
Such as those made by external contributors.
PeterJCLaw
force-pushed
the
fix-docs-ci-external-prs
branch
from
7511e32 to
bcdc499
Compare
Contributor
|
@prha Would you be the right person to ask to take a look at this? |
Contributor
|
Closing due to inactivity; please re-open if necessary, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Currently docs builds on PRs from external contributors have failing CI (such as https://github.com/dagster-io/dagster/actions/runs/5469013560/jobs/9957403116). This appears to be due to the way that the pull request is checked out, specifically this appears to have broken in #13796.
Also included here is a small change to ensure that the docs are rebuilt when the build logic changes (as well as when the docs themselves change).
I realise that CI still fails for external docs PRs due to the lack of secrets, however that's something harder for an external contributor to resolve. (I had a quick look to see if there were any other build jobs which should be running, but couldn't see any).
Alternatively, perhaps the CI job should be configured to skip itself for external PRs?
How I Tested These Changes
This CI run.