refactor asset health computations #29465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jamiedemaria
force-pushed
the
jamie/move-asset-health-query
branch
from
13b8645 to
2e4143e
Compare
jamiedemaria
force-pushed
the
jamie/move-asset-health-query
branch
from
2e4143e to
f472bb3
Compare
jamiedemaria
force-pushed
the
jamie/move-asset-health-query
branch
from
f472bb3 to
b6f9443
Compare
This was referenced Apr 25, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Moves the asset health computations to
asset_health.pyinstead of inasset_graph.pywith the other assetNode resolvers. This makes it more organized (all asset health related GQL stuff is in one file) and makes it so that you can query for just the freshness status and not have to recompute all other statuses.no logic changes, just moving code
How I Tested These Changes
existing tests