[resolved] split asset defs update and asset spec update handling

[alangenfeld]

Currently we just have AssetAttributes which we use to power both Definitions post processing as well as pre-definitions AssetSpec customization.

Unfortunately, these two context have different constraints. We do not support changing the key of an asset spec inside of an already formed AssetsDefinition as its difficult to ensure it could safely handle that transformation in all cases.

This change separates the two cases, and adds key_prefix for the spec only update condition.

How I Tested These Changes

added tests

[alangenfeld]

• [resolved] split asset defs update and asset spec update handling #29490 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[OwenKephart]

(as discussed offline) given that this doesn't work with AssetsDefinitions (just asset specs), and I would expect AssetsDefinitions to be more common, I feel like we should simply not support this pattern, even though it's a bit of a bummer.

generally, I think asset keys should be used purely as unique identifiers that are very domain-specific, and components themselves are often going to be the best place to encode that domain-specific information. adding prefixes at hierarchy levels feels a bit like an anti-pattern if it's used for organization (as you can use tags or groups for that purpose)

changes made

[OwenKephart]

nice, much prefer this

[alangenfeld]

Merge activity

• Apr 23, 11:40 AM CDT: A user started a stack merge that includes this pull request via Graphite.
• Apr 23, 11:41 AM CDT: A user merged this pull request with Graphite.