-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[docs] Update quickstart dg
#29495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update quickstart dg
#29495
Conversation
| 2. Activate the virtual environment: | ||
|
|
||
| <Tabs> | ||
| <TabItem value="macos" label="MacOS"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider creating a virtual environment component for re-usability.
neverett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but looks like Graphite might have caught an issue with the command in the Windows tab.
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
| </TabItem> | ||
| <TabItem value="windows" label="Windows"> | ||
| ```bash python -m venv venv source venv\Scripts\activate ``` | ||
| ```.venv\Scripts\activate``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Windows activation command is missing the code block markers. Please update to:
.venv\Scripts\activateThis ensures proper syntax highlighting and consistent formatting with the other code examples in the document.
| ```.venv\Scripts\activate``` | |
| ```bash | |
| .venv\Scripts\activate | |
| ``` |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Summary & Motivation
Update quickstart example to match with
dgNOTE Will require the installation instructions page to include steps for
dgHow I Tested These Changes
Changelog