[dg] Collapse load errors when invoking dg list defs #29507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpankow
force-pushed
the
benpankow/collapse-errors-list-defs
branch
3 times, most recently
from
dae0fe8 to
3c544e2
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
benpankow
force-pushed
the
benpankow/collapse-errors-list-defs
branch
from
3c544e2 to
09d3bc6
Compare
gibsondan
reviewed
Apr 23, 2025
Member
gibsondan
left a comment
gibsondan
left a comment
There was a problem hiding this comment.
just one question inline for sean, otherwise looks good
Comment on lines
99
to
105
| @click.option( | ||
| "--verbose", | ||
| "-v", | ||
| flag_value=True, | ||
| default=False, | ||
| help="Show verbose stack traces, including system frames in stack traces.", | ||
| ) |
Member
There was a problem hiding this comment.
@smackesey does the existance of this flag interact weirdly with any of the logging changes you are planning to make?
Member
Author
There was a problem hiding this comment.
I can also just drop this flag, it's never invoked right now
Collaborator
There was a problem hiding this comment.
does the existance of this flag interact weirdly with any of the logging changes you are planning to make?
this is in dagster-components, so no (my logging changes are in dg-land)-- fine to leave it in
benpankow
force-pushed
the
benpankow/collapse-errors-list-defs
branch
from
7ed1a57 to
f83097f
Compare
alangenfeld
approved these changes
Apr 23, 2025
dpeng817
pushed a commit
that referenced
this pull request
Apr 24, 2025
## Summary Collapse error messages when loading a repo for the purposes of `dg list defs`, in a similar vein to what we do for `dg dev` and `dg check defs`: ```sh $ dg list defs Using /Users/ben/repos/components_demo/missing-resource-demo/.venv/bin/dagster-components Loading location missing-resource-demo failed: dagster._core.errors.DagsterInvalidDefinitionError: resource with key 'my_resource' required by op 'my_asset' was not provided. Please provide a ResourceDefinition to key 'my_resource', or change the required key to one of the following keys which points to an ResourceDefinition: ['io_manager'] Stack Trace: [15 dagster system frames hidden, run dg check defs --verbose to see the full stack trace] An error occurred while executing a `dagster-components` command in the Python environment at /Users/ben/repos/components_demo/missing-resource-demo/.venv. `uv run dagster-components list definitions --location missing-resource-demo --module-name missing_resource_demo.definitions --output-file /var/folders/bc/4npnrqyd46l4vbbkdsdsw3_h0000gn/T/tmpspyxetpf` exited with code 1. Aborting. ``` Users are instructed to call `dg check defs --verbose` to get the full stacktrace. ## How I Tested These Changes New unit test, tested locally. ## Changelog > [dg] `dg list defs` now collapses long system stacktraces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Collapse error messages when loading a repo for the purposes of
dg list defs, in a similar vein to what we do fordg devanddg check defs:Users are instructed to call
dg check defs --verboseto get the full stacktrace.How I Tested These Changes
New unit test, tested locally.
Changelog