refactor(ui): standardize component library usage#2030
Merged
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR performs a comprehensive refactoring of the UI component architecture, migrating components from Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DAGStatus as DAGStatus Component
participant Graph as Graph/Mermaid
participant StepDrawer as StepDetailsDrawer
participant StepDetails as StepDetails
User->>DAGStatus: View DAG visualization
DAGStatus->>Graph: Render graph with onClickStep callback
User->>Graph: Click on step node
Graph->>DAGStatus: onClickStep(nodeId)
DAGStatus->>DAGStatus: Find matching step, set selectedDetailStep
DAGStatus->>DAGStatus: Set isStepDetailsOpen = true
DAGStatus->>StepDrawer: Render with step prop
StepDrawer->>StepDrawer: Focus close button on mount
StepDrawer->>StepDrawer: Attach keyboard listeners (Tab trap, Escape, arrows)
StepDrawer->>StepDetails: Render step content
User->>StepDrawer: Press Escape / Click overlay
StepDrawer->>DAGStatus: Call onClose()
DAGStatus->>DAGStatus: Set isStepDetailsOpen = false
StepDrawer->>StepDrawer: Restore focus to previous element
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
components/uiand add import guardrails for consistent component usage.Testing
pnpm typecheckpnpm testpnpm exec eslint --ext .ts,.tsx src/components/ui src/uieslinton touched graph/sidebar filespnpm vitest run src/features/dags/components/__tests__/DAGStatus.test.tsxpnpm build(passes with existing webpack asset-size warnings)Summary by CodeRabbit
New Features
Improvements
Style