Skip to content

Fix linter error#515

Merged
yottahmd merged 1 commit intodagucloud:mainfrom
rafiramadhana:fix-linter-basic-auth-test
Jan 1, 2024
Merged

Fix linter error#515
yottahmd merged 1 commit intodagucloud:mainfrom
rafiramadhana:fix-linter-basic-auth-test

Conversation

@rafiramadhana
Copy link
Copy Markdown
Contributor

@rafiramadhana rafiramadhana commented Jan 1, 2024

Fix error when running make go-lint

➜  dagu git:(main) ✗ make go-lint
service/frontend/middleware/basic_auth_test.go:14:10: Error return value of `w.Write` is not checked (errcheck)
		w.Write([]byte("OK"))
		       ^
make: *** [Makefile:83: go-lint] Error 1

This error affects make build, so I think it is quite important to fix this

@yottahmd yottahmd added the bug Something isn't working label Jan 1, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22f3138) 73.11% compared to head (ee08c95) 72.84%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   73.11%   72.84%   -0.27%     
==========================================
  Files          43       43              
  Lines        3678     3705      +27     
==========================================
+ Hits         2689     2699      +10     
- Misses        850      868      +18     
+ Partials      139      138       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yottahmd
Copy link
Copy Markdown
Collaborator

yottahmd commented Jan 1, 2024

Thank you so much!

@yottahmd yottahmd merged commit 41ca155 into dagucloud:main Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants