Fix plainMonthDay() default metavar to match canonical format#643
Fix plainMonthDay() default metavar to match canonical format#643
plainMonthDay() default metavar to match canonical format#643Conversation
The previous default metavar "--MONTH-DAY" was confusing in help text because it looked like a CLI option flag (e.g., --birthday --MONTH-DAY). The canonical format from toString() is "01-23" without the "--" prefix, so the metavar should match. Also updates the error message example to use "01-23" instead of "--01-23" for consistency. #306 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
#306 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
678d965 to
a4eeb41
Compare
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Code Review
This pull request changes the default metavar for plainMonthDay() from "--MONTH-DAY" to "MONTH-DAY" to improve clarity in help messages. This change is consistently applied across the implementation, documentation, and tests. The updated tests properly cover the new canonical format. The changes adhere to the project's coding and documentation style guides. No issues were found during the review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 94.91% 94.93% +0.01%
==========================================
Files 38 38
Lines 17614 17614
Branches 4679 4681 +2
==========================================
+ Hits 16718 16721 +3
+ Misses 884 881 -3
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
The
plainMonthDay()parser used"--MONTH-DAY"as its default metavar, which caused confusing help output. For example,--birthday --MONTH-DAYlooked like two separate option flags rather than an option followed by its value. The canonical format produced byformat()is"01-23"(without the--prefix), so the metavar has been changed to"MONTH-DAY"to match.The error message example in packages/temporal/src/index.ts has also been updated from
"--01-23"to"01-23"for consistency.Test plan
"MONTH-DAY""01-23","12-31") to valid input testsmise test)Closes #306