[#1933] Validate impulse_request values#1934
Merged
daid merged 5 commits intodaid:masterfrom Apr 4, 2024
Merged
Conversation
oznogon
commented
Mar 4, 2023
a7078c2 to
5a4d862
Compare
Owner
|
I see I totally forgot to reply to this. While the idea is feels sound on the first glance. There is an issue with it. It's still dividing by zero, and assuming that it will produce "infinity". But as we are compiling with |
Contributor
Author
|
Added a check to confirm that impulse_max_speed is greater than 0 before attempting setImpulseRequest. |
Tsht
pushed a commit
to Tsht/EmptyEpsilon
that referenced
this pull request
Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1933 shows that directly setting
impulse_requeston aSpaceShipcan result in unusable or poorly defined values, such as infinity/-infinity from dividing by 0 impulse speed on Odins and Defense Platforms.Add a
setImpulseRequest()function that clamps the passed value and replace direct modifications ofimpulse_requestwith it.Fixes #1933.