Skip to content

fix: Remove editorconfig duplicated settings for received and verifie…#311

Merged
samtrion merged 1 commit intomainfrom
samtrion-patch-1
Mar 5, 2026
Merged

fix: Remove editorconfig duplicated settings for received and verifie…#311
samtrion merged 1 commit intomainfrom
samtrion-patch-1

Conversation

@samtrion
Copy link
Contributor

@samtrion samtrion commented Mar 5, 2026

…d files

Remove editorconfig duplicated settings for received and verified files

Summary by CodeRabbit

  • Chores
    • Simplified editor configuration by removing unnecessary formatting rules for specific file types.

…d files

Remove editorconfig duplicated settings for received and verified files

Signed-off-by: Martin Stühmer <me@samtrion.net>
@samtrion samtrion self-assigned this Mar 5, 2026
@samtrion samtrion requested a review from a team as a code owner March 5, 2026 09:42
@samtrion samtrion requested review from Spacemonkay and removed request for a team March 5, 2026 09:42
@samtrion samtrion added state:ready for merge Indicates that a pull request has been reviewed and approved, and is ready to be merged into the mai type:bug Indicates an issue or flaw that needs to be fixed. labels Mar 5, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2ef57dbb-b4eb-4b7b-9b65-95e6e6a7fd68

📥 Commits

Reviewing files that changed from the base of the PR and between 9b8dfe6 and 0f2fc69.

📒 Files selected for processing (1)
  • src/NetEvolve.Defaults/configurations/editorconfig.txt
💤 Files with no reviewable changes (1)
  • src/NetEvolve.Defaults/configurations/editorconfig.txt

Walkthrough

Removed EditorConfig rules that previously enforced formatting behavior for .received.txt and .verified.txt files, specifically configuration for final newlines and trailing whitespace handling.

Changes

Cohort / File(s) Summary
EditorConfig Rules Removal
src/NetEvolve.Defaults/configurations/editorconfig.txt
Removed 4 lines of configuration for [*.{received,verified}.txt] pattern that enforced insert_final_newline = false and trim_trailing_whitespace = false.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hops through configs, neat and tidy,
Removes the rules for files spry,
.received and .verified fly free,
No more whitespace rules, let them be! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing duplicated editorconfig settings for received and verified files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@samtrion samtrion merged commit fd2010b into main Mar 5, 2026
9 checks passed
@samtrion samtrion deleted the samtrion-patch-1 branch March 5, 2026 10:39
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (9b8dfe6) to head (0f2fc69).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #311   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:ready for merge Indicates that a pull request has been reviewed and approved, and is ready to be merged into the mai type:bug Indicates an issue or flaw that needs to be fixed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant