feat(analyzers): add support for recommended analyzer packages and va…#374
feat(analyzers): add support for recommended analyzer packages and va…#374
Conversation
samtrion
added
state:ready for merge
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 11 minutes and 33 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR introduces a new NED0010 diagnostic to validate recommended analyzer packages during builds, updates analyzer package versions in the package manifest, and enhances documentation with formatting improvements and a new diagnostic specification page. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/NetEvolve.Defaults/buildMultiTargeting/SupportMissingAnalyzers.targets`:
- Around line 25-37: The Warning and Error elements that emit NED0010 (the
Warning/Error elements with Code="NED0010" that check
'@(MissingRequiredAnalyzerPackage)' and '$(TreatWarningsAsErrors)') do not
respect $(NoWarn); update both Conditions to also ensure the NED0010 code is not
present in $(NoWarn) (i.e., skip emitting if NoWarn includes "NED0010").
Concretely, modify the Condition expressions on the Warning and Error elements
that reference '@(MissingRequiredAnalyzerPackage)' so they additionally check
that $(NoWarn) does not contain "NED0010" (use an MSBuild-safe string/regex
check) so users can suppress NED0010 via NoWarn as documented.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d144fb1d-35a6-4be5-8c3c-4c1f4832b878
📒 Files selected for processing (7)
.editorconfigDirectory.Packages.propsREADME.mddocs/usage/ned0010.mdsrc/NetEvolve.Defaults/README.mdsrc/NetEvolve.Defaults/buildMultiTargeting/NetEvolve.Defaults.targetssrc/NetEvolve.Defaults/buildMultiTargeting/SupportMissingAnalyzers.targets
…opyright year validation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
…lidation logic
Summary by CodeRabbit
New Features
Documentation
Chores