Skip to content

test: Increase SlowMessageTransport delay to reduce test flakiness#435

Merged
samtrion merged 1 commit intomainfrom
test/flaky-test
Apr 20, 2026
Merged

test: Increase SlowMessageTransport delay to reduce test flakiness#435
samtrion merged 1 commit intomainfrom
test/flaky-test

Conversation

@samtrion
Copy link
Copy Markdown
Contributor

@samtrion samtrion commented Apr 20, 2026

The delay in ExecuteAsync_WithPerEventTypeProcessingTimeout_UsesOverride was raised from 200ms to 5s to ensure it exceeds the override timeout, minimizing timer-jitter and improving test reliability.

Summary by CodeRabbit

  • Tests
    • Improved test reliability for processing timeout validation by adjusting timing parameters.

The delay in ExecuteAsync_WithPerEventTypeProcessingTimeout_UsesOverride was raised from 200ms to 5s to ensure it exceeds the override timeout, minimizing timer-jitter and improving test reliability.
@samtrion samtrion self-assigned this Apr 20, 2026
@samtrion samtrion requested a review from a team as a code owner April 20, 2026 13:21
@samtrion samtrion requested a review from benwirren April 20, 2026 13:21
@samtrion samtrion added state:ready for merge Indicates that a pull request has been reviewed and approved, and is ready to be merged into the mai type:chore Indicates some housework that needs to be done. labels Apr 20, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aaf5fa17-ce00-4fb4-8edb-fe40c0058b86

📥 Commits

Reviewing files that changed from the base of the PR and between dade20a and e095ad1.

📒 Files selected for processing (1)
  • tests/NetEvolve.Pulse.Tests.Unit/Outbox/OutboxProcessorHostedServiceTests.cs

Walkthrough

A test timeout value is increased in the outbox processor hosted service tests to ensure reliable triggering of per-event-type processing timeouts during message transport operations.

Changes

Cohort / File(s) Summary
Test Timeout Configuration
tests/NetEvolve.Pulse.Tests.Unit/Outbox/OutboxProcessorHostedServiceTests.cs
Increased SlowMessageTransport delay from 200ms to 5 seconds in ExecuteAsync_WithPerEventTypeProcessingTimeout_UsesOverride test to reliably trigger processing timeout behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop, a skip, a timer's call,
Five seconds now, no jitter at all!
The test waits long, the timeout true,
No more surprises—just what we knew! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: increasing SlowMessageTransport delay to reduce test flakiness, which matches the actual modification in the test file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.78%. Comparing base (dade20a) to head (e095ad1).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   92.36%   92.78%   +0.41%     
==========================================
  Files         159      159              
  Lines        5960     5960              
  Branches      539      539              
==========================================
+ Hits         5505     5530      +25     
+ Misses        302      277      -25     
  Partials      153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samtrion samtrion merged commit 4ffc7d8 into main Apr 20, 2026
9 checks passed
@samtrion samtrion deleted the test/flaky-test branch April 20, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:ready for merge Indicates that a pull request has been reviewed and approved, and is ready to be merged into the mai type:chore Indicates some housework that needs to be done.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant