Sidebar.spec: 'should require login before opening following for anonymous users' is red on main

[tsahimatsliah]

Summary

packages/shared/src/components/sidebar/Sidebar.spec.tsx → should require login before opening following for anonymous users has been failing on main since the sidebar rework landed.

Failing test

it('should require login before opening following for anonymous users', async () => {
  renderComponent(defaultAlerts, [createMockFeedSettings()], undefined);
  const item = await screen.findByText('Following');

  fireEvent.click(item);

  expect(showLogin).toHaveBeenCalledWith({
    trigger: 'Following',
  });
});

Observed error

expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: {"trigger": "Following"}
Number of calls: 0

showLogin is never invoked when an anonymous user clicks the Following sidebar item. The Following entry in sidebar/sections/MainSection.tsx is set to requiresLogin: true, and SidebarItem / ClickableNavItem look correct on a static read, so the regression is subtle.

Where it originated

Introduced as part of ee36f20e7 feat: add happening now to sidebar — the commit switched renderComponent(..., null) to renderComponent(..., undefined) and moved the settings context over to createTestSettings(...). I suspect the regression is in how the new createTestSettings fixture or the undefined user path flows through AuthContext, rather than a product bug.

Impact

• test_shared → build workflow is red on main (confirmed on tip-of-main 63f752532): https://app.circleci.com/pipelines/gh/dailydotdev/apps/ (see any recent main build).
• Any PR that merges main in — e.g. feat(shortcuts): redesign new-tab shortcuts hub #5903 — inherits the red check, blocking merges on anything that requires a green build.

Reproduction

git checkout main
pnpm --filter @dailydotdev/shared test -- --testPathPattern='sidebar/Sidebar.spec'

→ Tests: 1 failed, 10 passed, 11 total.

Suggested fix

Either restore the old SettingsContextData fixture in the test (to rule out the fixture change) or add a console/print inside ClickableNavItem.onClick to confirm whether showLogin is being invoked with an unexpected argument, or the click target is not the anchor with the handler.

cc @idoshamun — this was from the "happening now" sidebar rework; happy to pair on a fix if helpful, but flagging here so it can be picked up on main.

[tsahimatsliah]

Fixed on this PR's branch () — the failure was an ES default-parameter gotcha in the spec's own renderComponent helper, not in the product code: the signature was user: LoggedUser | undefined = defaultUser, and callers explicitly passing undefined to represent an anonymous user were silently getting logged back in as defaultUser. Reshaped the helper into an options-bag with an explicit isAnonymous flag so "no user" has its own discriminant. All 11 Sidebar.spec tests pass; test_shared and the build workflow are green on the PR. Happy to cherry-pick onto main if you'd like.