feat(funnels): app directory and web funnel setup #4312
Conversation
…app-directory-helloworld
…app-directory-helloworld
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
| export const ACCEPTED_TYPES = 'image/png,image/jpeg'; | ||
| export const acceptedTypesList = ACCEPTED_TYPES.split(','); |
There was a problem hiding this comment.
Since they are used on server side code we should not mix with client-side one.
…app-directory-helloworld
ilasw
changed the title
packages/shared/package.json
Outdated
| "jotai": "^2.12.2", | ||
| "jotai-tanstack-query": "^0.9.0", |
There was a problem hiding this comment.
If we are not using lets remove dependencies for now
| <meta | ||
| name="viewport" | ||
| content="initial-scale=1.0, width=device-width, viewport-fit=cover" | ||
| /> | ||
|
|
||
| <meta name="application-name" content="daily.dev" /> | ||
| <meta name="apple-mobile-web-app-capable" content="yes" /> | ||
| <meta name="apple-mobile-web-app-title" content="daily.dev" /> | ||
| <meta name="format-detection" content="telephone=no" /> | ||
| <meta name="mobile-web-app-capable" content="yes" /> | ||
| <meta name="slack-app-id" content="A07AM7XC529" /> | ||
| <meta name="apple-itunes-app" content="app-id=6740634400" /> |
There was a problem hiding this comment.
There was a problem hiding this comment.
But non blocking since I see you reused it so we don't have to update both places, we just need to make sure we move at some point.
There was a problem hiding this comment.
Maybe I can add a todo for this?
| } => { | ||
| const params = useSearchParams(); | ||
| return { | ||
| query: Object.fromEntries(params.entries()), |
There was a problem hiding this comment.
useMemo, params is stable so it should actually memoize quite nicely
packages/webapp/app/app-boot.ts
Outdated
| const state = dehydrate(queryClient, { shouldDehydrateQuery: () => true }); // to also include Errors | ||
|
|
||
| if (!boot) { | ||
| throw new Error('Failed to fetch boot data'); | ||
| } |
There was a problem hiding this comment.
fetchQuery will throw, so Promise will reject either way so you don't need this I think
rebelchris
left a comment
rebelchris
left a comment
There was a problem hiding this comment.
Nothing blocking from my side.
Just make sure to do critical flow testing once deployed just to be safe.
| @@ -0,0 +1,36 @@ | |||
| import type { Boot } from '@dailydotdev/shared/src/lib/boot'; | |||
There was a problem hiding this comment.
Slightly triggered by the file name app-boot.ts 🙈 (because of the hyphen)
There was a problem hiding this comment.
Renamed for the common wealth 😄
packages/webapp/app/layout.tsx
Outdated
| import React from 'react'; | ||
| import Head from 'next/head'; | ||
| import Providers from './providers'; | ||
| import { AppHeadMetas } from '../../shared/src/features/common/components/AppHeadMetas'; |
omBratteng
left a comment
omBratteng
left a comment
There was a problem hiding this comment.
LGTM – only two non-blocking comments
Changes
useAppAuthhook for get boot data from the SSR queriesEvents
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://feat-app-directory-helloworld.preview.app.daily.dev