Skip to content

feat: add support for conditional cookie consent banner display #4440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilasw merged 2 commits into from
Apr 22, 2025
Merged

feat: add support for conditional cookie consent banner display #4440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8b3bb6
feat: add support for conditional cookie consent banner display
ilasw Apr 22, 2025
170c00e
feat: add support for conditional cookie consent banner display
ilasw Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/shared/src/features/onboarding/shared/FunnelStepper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export const FunnelStepper = ({
onNavigation: trackOnNavigate,
});
const { transition: sendTransition } = useStepTransition(session.id);
const isCookieBannerActive = !!funnel?.parameters?.cookieConsent?.show;
const { showBanner, ...cookieConsentProps } = useFunnelCookies({
defaultOpen: showCookieBanner,
trackFunnelEvent,
Expand Down Expand Up @@ -146,7 +147,7 @@ export const FunnelStepper = ({
onScrollCapture={trackOnScroll}
className="flex min-h-dvh flex-col"
>
{showBanner && (
{isCookieBannerActive && showBanner && (
<CookieConsent key="cookie-consent" {...cookieConsentProps} />
)}
<FunnelStepBackground step={step}>
Expand Down
6 changes: 5 additions & 1 deletion packages/shared/src/features/onboarding/types/funnel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,11 @@ export type FunnelPosition = {
export interface FunnelJSON {
id: string;
version: number;
parameters: FunnelStepParameters;
parameters: FunnelStepParameters<{
cookieConsent: {
show: boolean;
};
}>;
entryPoint: FunnelStep['id'];
chapters: Array<FunnelChapter>;
}
Expand Down