Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
capJavert
requested review from
AmarTrebinjac,
ilasw,
nensidosari,
omBratteng,
rebelchris and
sshanzel
rebelchris
approved these changes
Sep 22, 2025
Contributor
rebelchris
left a comment
rebelchris
left a comment
There was a problem hiding this comment.
Nice the zod-hookform is really neat!
| import z from 'zod'; | ||
| import { labels } from '../labels'; | ||
|
|
||
| export const opportunityEditInfoSchema = z.object({ |
Contributor
Author
There was a problem hiding this comment.
yeah, @dailydotdev/common when 😆
Contributor
Author
There was a problem hiding this comment.
gathering is close, we could hack it there...
Comment on lines
+305
to
+311
| const canEdit = useMemo(() => { | ||
| if (!user) { | ||
| return false; | ||
| } | ||
|
|
||
| return !!opportunity?.recruiters?.some((item) => item.id === user.id); | ||
| }, [opportunity, user]); |
Contributor
There was a problem hiding this comment.
We need another layer I think.
If draft && !recruiter redirect away.
Contributor
Author
There was a problem hiding this comment.
yeah but for now I just kept it open until I connect step two and draft state this week 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
API PR dailydotdev/daily-api#3143
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://job-edit.preview.app.daily.dev