fix: allow adding continent to opportunity#5024
Merged
Merged
Conversation
Currently only empty or Europe
omBratteng
requested review from
AmarTrebinjac,
capJavert,
ilasw,
nensidosari,
rebelchris and
sshanzel
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rebelchris
requested changes
Oct 30, 2025
rebelchris
left a comment
rebelchris
left a comment
Contributor
There was a problem hiding this comment.
Can you check though, think now the edit always expects country + subdivision etc.
rebelchris
approved these changes
Oct 30, 2025
rebelchris
left a comment
rebelchris
left a comment
Contributor
There was a problem hiding this comment.
ok, but maybe support any continent?
| city: z.string().max(240).optional(), | ||
| subdivision: z.string().max(240).optional(), | ||
| continent: z | ||
| .union([z.literal('Europe'), z.literal(''), z.undefined()]) |
Contributor
There was a problem hiding this comment.
Could technically be more?
Contributor
Author
There was a problem hiding this comment.
Said Europe for now, no?
Contributor
There was a problem hiding this comment.
Think also one for US technically, but maybe Country is ok there.
It's ok for this demo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Currently only empty or Europe
API PR
dailydotdev/daily-api#3243
Preview domain
https://fix-opp-continent.preview.app.daily.dev