fix: hide new quest badge for users created less than 24 hours ago#5880
Merged
AmarTrebinjac merged 2 commits intomainfrom Apr 19, 2026
Merged
Conversation
Users who just registered see everything as new, making the "new" quest rotation badge confusing and distracting from onboarding. This adds an account age check so the badge only appears for accounts older than 24h. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ade-in-the-last-24-hours
AmarTrebinjac
deleted the
eng-1263-dont-show-new-on-quests-for-users-made-in-the-last-24-hours
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuestButtonso the "new" quest rotation badge is hidden for users whose account is less than 24 hours oldhasNewQuestRotationsflag withisAccountOlderThan24Hours, which means themarkQuestRotationsViewedmutation also won't fire for new usersKey decisions
hasNewQuestRotationsderivation point — all downstream consumers (badge, aria labels, mark-as-viewed effect) automatically benefitDate.now()andnew Date()for the 24-hour comparisonrenderComponentin tests to use named parameters for better readability when passingauthTest plan
user.createdAt< 24h agouser.createdAt> 24h agoCloses ENG-1263
Created by Huginn 🐦⬛
Preview domain
https://eng-1263-dont-show-new-on-quests.preview.app.daily.dev