Skip to content

feat: show claimable milestone count badge on Game Center sidebar item#5881

Merged
AmarTrebinjac merged 2 commits intomainfrom
eng-1264-show-milestone-waiting-to-be-claimed
Apr 19, 2026
Merged

feat: show claimable milestone count badge on Game Center sidebar item#5881
AmarTrebinjac merged 2 commits intomainfrom
eng-1264-show-milestone-waiting-to-be-claimed

Conversation

@AmarTrebinjac
Copy link
Copy Markdown
Contributor

@AmarTrebinjac AmarTrebinjac commented Apr 16, 2026

Summary

  • Add a count badge to the Game Center sidebar menu item showing the number of milestone quests waiting to be claimed
  • Reuses the existing useQuestDashboard hook to derive claimable count — no new API calls needed
  • Badge styling matches the Pending Posts badge exactly (Typography with TypographyColor.Secondary, bold, rounded-6 bg-background-subtle px-1.5)
  • Badge only renders when claimableMilestoneCount > 0 and updates reactively via existing cache invalidation

Test plan

  • Strict typecheck passes on changed file
  • ESLint passes with 0 warnings
  • Sidebar spec tests pass (11/11)
  • Verify badge appears when milestone quests have claimable: true
  • Verify badge disappears after all milestones are claimed
  • Verify badge styling matches Pending Posts badge
  • Verify no badge shown for logged-out users

Closes ENG-1264


Created by Huginn 🐦‍⬛

Preview domain

https://eng-1264-show-milestone-waiting.preview.app.daily.dev

Add a count badge to the Game Center sidebar menu item that displays
the number of milestone quests waiting to be claimed. Uses the existing
useQuestDashboard hook data and follows the Pending Posts badge pattern.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Apr 19, 2026 2:03pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Apr 19, 2026 2:03pm

Request Review

@AmarTrebinjac AmarTrebinjac merged commit d6fd44a into main Apr 19, 2026
13 checks passed
@AmarTrebinjac AmarTrebinjac deleted the eng-1264-show-milestone-waiting-to-be-claimed branch April 19, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant