Skip to content

feat(shared): remove notification cta v2 flag#5893

Merged
idoshamun merged 2 commits intomainfrom
eng-1287-remove-notification_cta_v2-feature-flag-apply-control
Apr 20, 2026
Merged

feat(shared): remove notification cta v2 flag#5893
idoshamun merged 2 commits intomainfrom
eng-1287-remove-notification_cta_v2-feature-flag-apply-control

Conversation

@rebelchris
Copy link
Copy Markdown
Contributor

@rebelchris rebelchris commented Apr 20, 2026

Summary

  • remove the notification_cta_v2 feature definition and delete the experiment hook
  • keep the control notification CTA behavior as the permanent default in shared notification surfaces
  • remove v2-only CTA triggers, follow-up components, and squad share reminder code paths

Key decisions

  • preserved the original control rendering in EnableNotification instead of keeping a simplified variant that changed the notifications-page layout
  • removed experiment-only follow/join/upvote CTA plumbing entirely rather than leaving dormant props or branches behind
  • restored the control success toast for squad sharing so notification prompts are no longer shown from that flow

Closes ENG-1287


Created by Huginn 🐦‍⬛

Preview domain

https://eng-1287-remove-notification-cta.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Apr 20, 2026 0:04am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Apr 20, 2026 0:04am

Request Review

@idoshamun idoshamun merged commit 81433e3 into main Apr 20, 2026
12 checks passed
@idoshamun idoshamun deleted the eng-1287-remove-notification_cta_v2-feature-flag-apply-control branch April 20, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants