Skip to content

fix: let sidebar squad lists expand without clipping#5905

Merged
rebelchris merged 2 commits into
mainfrom
codex/fix-sidebar-squads-overflow
Apr 22, 2026
Merged

fix: let sidebar squad lists expand without clipping#5905
rebelchris merged 2 commits into
mainfrom
codex/fix-sidebar-squads-overflow

Conversation

@rebelchris
Copy link
Copy Markdown
Contributor

@rebelchris rebelchris commented Apr 22, 2026 •
edited by github-actions Bot
Loading

Summary

  • remove the hard-coded expanded section height cap from shared sidebar sections
  • use a content-driven collapse animation so long squad lists can fully render
  • keep overflow handling on the existing scrollable sidebar container

Testing

  • NODE_ENV=test pnpm --filter @dailydotdev/shared exec jest packages/shared/src/components/sidebar/Sidebar.spec.tsx packages/shared/src/components/sidebar/SidebarItem.spec.tsx --runInBand
  • strict shared TypeScript check currently fails in this worktree due to unrelated pre-existing errors outside this change

Preview domain

https://codex-fix-sidebar-squads-overflo.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 22, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Apr 22, 2026 8:10am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Apr 22, 2026 8:10am

Request Review

@rebelchris rebelchris merged commit 91391e4 into main Apr 22, 2026
13 checks passed
@rebelchris rebelchris deleted the codex/fix-sidebar-squads-overflow branch April 22, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rebelchris