Skip to content

refactor: split live room standup components#5987

Merged
idoshamun merged 1 commit into
mainfrom
codex/refactor-live-room-standups
May 5, 2026
Merged

refactor: split live room standup components#5987
idoshamun merged 1 commit into
mainfrom
codex/refactor-live-room-standups

Conversation

@idoshamun
Copy link
Copy Markdown
Member

@idoshamun idoshamun commented May 5, 2026

What changed

  • Split the /standups/[id] live room surface into focused header, stage, lobby, reactions, settings, and tooltip components.
  • Moved countdown, standup analytics, and stage data shaping into dedicated hooks.
  • Kept the existing page wrapper and live room behavior intact while reducing the amount of logic inside LiveRoom.tsx and LiveRoomControls.tsx.

Impact

  • Makes the standup/live room components easier to follow and maintain without changing the user-facing flow.
  • Keeps chat, queue, moderation, stage rendering, reactions, settings, and subscription behavior on the existing contracts.

Validation

  • pnpm --filter @dailydotdev/shared exec eslint src/components/liveRooms/LiveRoom.tsx src/components/liveRooms/LiveRoomControls.tsx src/components/liveRooms/LiveRoomHeader.tsx src/components/liveRooms/LiveRoomLobbyContent.tsx src/components/liveRooms/LiveRoomReactionOverlay.tsx src/components/liveRooms/LiveRoomReactionsToolbar.tsx src/components/liveRooms/LiveRoomSettingsModal.tsx src/components/liveRooms/LiveRoomStage.tsx src/components/liveRooms/LiveRoomTooltipButton.tsx src/hooks/liveRooms/useCountdownSeconds.ts src/hooks/liveRooms/useLiveRoomStandupAnalytics.ts src/hooks/liveRooms/useLiveRoomStageModel.ts
  • node ./scripts/typecheck-strict-changed.js
  • NODE_ENV=test pnpm --filter @dailydotdev/shared exec jest src/components/liveRooms/LiveRoom.spec.tsx src/components/liveRooms/LiveRoomControls.spec.tsx --runInBand

Note: the focused Jest run passes with the existing React act(...) warning around async busy-state cleanup in LiveRoomControls.

Preview domain

https://codex-refactor-live-room-standup.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview May 5, 2026 7:56am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored May 5, 2026 7:56am

Request Review

@idoshamun idoshamun force-pushed the codex/refactor-live-room-standups branch from 35bda4f to 8199ef5 Compare May 5, 2026 07:51
@idoshamun idoshamun marked this pull request as ready for review May 5, 2026 08:01
@idoshamun idoshamun merged commit 7380e1d into main May 5, 2026
12 of 14 checks passed
@idoshamun idoshamun deleted the codex/refactor-live-room-standups branch May 5, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant