chore(feed-settings): rename highlights toggle copy to "Happening Now"#6025
Merged
Conversation
The card surfaced by the highlights feature is labeled "Happening Now" everywhere it appears in the UI (HighlightCards, sidebar widget, quest button, etc.), so the Feed Settings toggle copy should match the user-facing terminology rather than the internal "highlights" name.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The highlights card surfaced in the feed is labeled "Happening Now" everywhere in the UI (
HighlightCards,HighlightPostSidebarWidget, sidebarMainSection,QuestButton,HighlightsPage, etc.). The Feed Settings toggle was using the internal "highlights" name, which mismatches what users see.Changes:
Pure copy change — no behavior change, the underlying
highlightsFirstEnabledflag name stays the same.Test plan
pnpm run typecheck:strict:changedcleanPreview domain
https://chore-happening-now-copy.preview.app.daily.dev