fix: focus comment composer when ready#6090
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
capJavert
reviewed
May 21, 2026
Comment on lines
+537
to
+549
| useEffect(() => { | ||
| if (!pendingFocusRef.current) { | ||
| return undefined; | ||
| } | ||
|
|
||
| const frame = requestAnimationFrame(() => { | ||
| if (focusEditorInput()) { | ||
| pendingFocusRef.current = false; | ||
| } | ||
| }); | ||
|
|
||
| return () => cancelAnimationFrame(frame); | ||
| }, [focusEditorInput]); |
Contributor
There was a problem hiding this comment.
Sounds like focus should be in click handler not useEffect, maybe editor exposes id/data-*/attribute so that it can be focused in dom
rebelchris
force-pushed
the
codex/fix-comment-composer-focus
branch
from
26e4139 to
86e7d8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
pnpm --filter shared test -- src/components/fields/RichTextInput.spec.tsx src/components/post/NewComment.spec.tsx src/components/comments/MainComment.spec.tsx src/components/comments/SubComment.spec.tsxNODE_ENV=test pnpm --filter webapp exec jest __tests__/PostPage.tsx --runInBand -t "should open new comment modal and set the correct props"node ./scripts/typecheck-strict-changed.jsgit diff --checkPreview: https://fix-comment-composer-focus.preview.app.daily.dev