Skip to content

feat: more gamificatiomn opts#6110

Merged
AmarTrebinjac merged 7 commits into
mainfrom
update-gamification-settings
May 29, 2026
Merged

feat: more gamificatiomn opts#6110
AmarTrebinjac merged 7 commits into
mainfrom
update-gamification-settings

Conversation

@AmarTrebinjac
Copy link
Copy Markdown
Contributor

@AmarTrebinjac AmarTrebinjac commented May 28, 2026

Changes

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://update-gamification-settings.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview May 29, 2026 10:41am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored May 29, 2026 10:41am

Request Review

@AmarTrebinjac
Copy link
Copy Markdown
Contributor Author

@claude please fix the build errors

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 29, 2026

Claude finished @AmarTrebinjac's task in 9m 32s —— View job


Fixed build errors ✅

The repo's strict-typecheck guard (scripts/typecheck-strict-changed.js) was failing on three modified files. Fixed in commit 3927c9d:

  • pages/[userId]/achievements.tsx — Added || !user to the early-return guard. ProfileLayoutProps extends Partial<ProfileV2> so user is optional, matching the same if (!user) return null pattern in ProfileLayout/index.tsx.
  • ReadingOverview.tsx — Made readHistory, streak, mostReadTags props optional. The component already defends against undefined internally (!!streak, Array.isArray(readHistory), etc.), so this just aligns the type signature with the actual usage in ProfileWidgets.tsx that passes readingHistory?.userReadHistory etc.
  • pages/game-center/index.tsxQuestDestination is a discriminated union of { path } and { href, openInNewTab? }. handleMilestoneDestinationClick was unconditionally using .path. Now mirrors the same 'href' in destination branching used in QuestButton.tsx.

Verification:

  • node ./scripts/typecheck-strict-changed.js → ✅ clean
  • pnpm --filter webapp lint → ✅ clean
  • pnpm --filter shared lint → ✅ clean
    • Branch: update-gamification-settings

Co-authored-by: Amar Trebinjac <AmarTrebinjac@users.noreply.github.com>
@AmarTrebinjac AmarTrebinjac marked this pull request as ready for review May 29, 2026 10:36
@AmarTrebinjac AmarTrebinjac enabled auto-merge (squash) May 29, 2026 10:36
@AmarTrebinjac AmarTrebinjac merged commit 1768e1a into main May 29, 2026
13 checks passed
@AmarTrebinjac AmarTrebinjac deleted the update-gamification-settings branch May 29, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant