fix(giveback): tab-nav alignment + deferred polish + analytics gap#6261
Merged
Conversation
… gap The remaining items after reconciling against the design source: - Tab nav gutter now matches the page column (px-4 tablet:px-8 laptop:px-12) so the tabs line up with the content on tablet+; relabel 'Impact' -> 'Your impact'. - useGivebackCauseSelection.save() force-clears the 'Your causes are saved' toast after 3s, since the global toast only auto-dismisses when the user's setting is on (deferred earlier, now imported). - Updated the /giveback SEO description to the new messaging. - GivebackCauseCard now logs ClickGivebackCause on 'Learn more', closing the gap where the funnel + 'more causes' grid weren't tracked (the causes-tab row already logged).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
autoDismissNotifications defaults to true, so the {timer: 3000} option
already auto-dismisses the save toast for the default majority. The manual
queryClient force-clear only did anything for users who explicitly turned
auto-dismiss off, where it overrode their choice. Removed it (and the ref,
cleanup effect, and queryClient/TOAST_NOTIF_KEY usage); the toast now
respects the user setting like every other toast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining gaps after reconciling our
mainagainst the #6247 design source.px-4 tablet:px-8 laptop:px-12but the tab-nav container stayedpx-4, so the tabs didn't line up with the content (hero/panels/footer) on tablet+. Now matched. Also relabels "Impact" → "Your impact".save()passes{ timer: 3000 }so the "Your causes are saved" toast auto-dismisses for users on auto-dismiss (the default). Note: the feat(giveback): full design pass — warm-up funnel, reward-ladder impact, causes tab #6247 source also force-cleared the toast via the query cache; dropped that —autoDismissNotificationsdefaults to true so the timer already handles the common case, and the force-clear only overrode the choice of users who opted out./givebackmeta description updated to the new messaging.GivebackCauseCardnow logsClickGivebackCauseon "Learn more", covering the funnel + "more causes" grid (the causes-tab row already logged it).Verification
tsc: no new errors