Skip to content

fix: 404 empty paginated sitemap pages#3797

Merged
idoshamun merged 2 commits intomainfrom
codex/fix-empty-paginated-sitemaps
Apr 15, 2026
Merged

fix: 404 empty paginated sitemap pages#3797
idoshamun merged 2 commits intomainfrom
codex/fix-empty-paginated-sitemaps

Conversation

@idoshamun
Copy link
Copy Markdown
Member

Summary

  • return 404 for paginated posts and evergreen sitemap pages when the requested page has no rows
  • stop generating sitemap index entries for empty paginated sitemap families
  • add coverage for empty paginated sitemap requests

Testing

  • pnpm -s jest tests/sitemaps.ts --testEnvironment=node --runInBand -t "posts-:page|evergreen.xml|index.xml"

@pulumi
Copy link
Copy Markdown

pulumi bot commented Apr 15, 2026

🍹 The Update (preview) for dailydotdev/api/prod (at ae697a3) was successful.

✨ Neo Explanation

Routine deployment bumping all workloads to commit `574a2a57`, with fresh DB and ClickHouse migration jobs running against the new image. ✅ Low Risk

This is a standard application deployment rolling out a new build (574a2a57) to replace the previous one (26681605). All deployments and cron jobs are receiving only an image tag and version label update. The two migration Jobs (Postgres via TypeORM and ClickHouse) are being cycled by design — Pulumi names them with the commit SHA, so each deploy deletes the old job and creates a new one to run migrations against the new schema.

🔵 Info — The GCP provider warning about missing credentials is cosmetic for this Kubernetes-only update; it does not affect the apply.

Resource Changes

    Name                                                       Type                           Operation
~   vpc-native-post-analytics-history-day-clickhouse-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-expired-better-auth-sessions-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-generic-referral-reminder-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-channel-highlights-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-sync-subscription-with-cio-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-deployment                  kubernetes:apps/v1:Deployment  update
~   vpc-native-daily-digest-cron                               kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-stale-user-transactions-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-user-posts-analytics-refresh-cron               kubernetes:batch/v1:CronJob    update
-   vpc-native-api-clickhouse-migration-26681605               kubernetes:batch/v1:Job        delete
~   vpc-native-user-profile-updated-sync-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-generate-search-invites-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-analytics-clickhouse-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-analytics-history-clickhouse-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-bg-deployment                                   kubernetes:apps/v1:Deployment  update
~   vpc-native-hourly-notification-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-rotate-daily-quests-cron                        kubernetes:batch/v1:CronJob    update
-   vpc-native-api-db-migration-26681605                       kubernetes:batch/v1:Job        delete
~   vpc-native-private-deployment                              kubernetes:apps/v1:Deployment  update
~   vpc-native-calculate-top-readers-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-update-highlighted-views-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-materialized-views-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-materialize-yearly-best-post-archives-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-channel-digests-cron                            kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-images-cron                        kubernetes:batch/v1:CronJob    update
+   vpc-native-api-clickhouse-migration-574a2a57               kubernetes:batch/v1:Job        create
~   vpc-native-check-analytics-report-cron                     kubernetes:batch/v1:CronJob    update
~   vpc-native-expire-super-agent-trial-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-channel-highlights-cron                         kubernetes:batch/v1:CronJob    update
~   vpc-native-deployment                                      kubernetes:apps/v1:Deployment  update
+   vpc-native-api-db-migration-574a2a57                       kubernetes:batch/v1:Job        create
~   vpc-native-update-views-cron                               kubernetes:batch/v1:CronJob    update
~   vpc-native-rotate-weekly-quests-cron                       kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-public-threshold-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-users-cron                         kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-gifted-plus-cron                          kubernetes:batch/v1:CronJob    update
~   vpc-native-update-trending-cron                            kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-clickhouse-cron                  kubernetes:batch/v1:CronJob    update
... and 11 other changes

@idoshamun idoshamun merged commit da6165f into main Apr 15, 2026
10 checks passed
@idoshamun idoshamun deleted the codex/fix-empty-paginated-sitemaps branch April 15, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant