-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Refactor the touch logic and usage. #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1.The surface and bottom view could be clickable and longClickable, and it's selector drawables works fine; 2.The swipeLayout can wrap in other gestural layout, the swipe and other layout's gesture work's pretty;
|
@daimajia Translation: I think we can remove the constriction of the surfaceView and the bottomView which must be a subclass of the ViewGroup, and we can use layout_gravity to indicate the swiping direction (just like DrawerLayout). |
|
@linfaxin I'll check this PR later, thanks for your work on this project! ^.^ and i'm going to consider your idea seriously ( removing the constriction on the surfaceView and bottomView, and using layout_gravity to indicate the swipe direction) before replying you. |
…is the root of AdapterView's item,
The bottom view can use layout_gravity to indicate the swiping direction
…l auto close when click on it's surface view
|
Improve the release drag logic, easy to open and close. |
|
@linfaxin would be interesting that willOpenPercent will be customizable. |
|
I see no SDK widget custom this. Maybe it's impossible? |
|
On SwipeLayout.java Line 1221: And: |
|
Sorry, for my bad English. I mean it maybe not necessary. |
|
Hi, Mr @linfaxin . Thanks your work on this project. Really sorry for my late reply cause recently was busy on some other heavy stuff. I'll renew this project, and try to update every day. :-D |
|
@linfaxin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useless try catch
|
Wait your merge :) |
Refactor the touch logic and usage.
|
@linfaxin May I add your wechat if you don't mind. |
|
@daimajia I sent you a email :) please check |
|
@eduplus Please check the latest release v1.2.0 . I have pushed it to maven. |
|
@daimajia That fixed our issue. Great, thanks a ton. |
1.The surface and bottom view could be clickable and longClickable, and it's selector drawables works fine;
2.The swipeLayout can wrap in other gestural layout, the swipe and other layout's gesture work's pretty;