Skip to content

Conversation

@mcumings
Copy link
Contributor

The interactions with the BaseAdapter and RecyclerView.Adapter in the SwipeItemManagerImpl code were unnecessarily coupled to the underlying implementations. This refactor allows API users to utilize the state management provided by SwipeItemManagerImpl without having to extend any of the utility base classes. It also dramatically simplifies the code to attain better cohesion.

@daimajia
Copy link
Owner

daimajia commented May 1, 2015

This is an awesome code refractor! Thanks your working on this.

Before I merge this PR, i need to mention the other collaborators of this porject to let them know the change of the code, and make code review.
@linfaxin @jpshelley

@jpshelley
Copy link
Collaborator

@daimajia I trust you to verify it. Otherwise if you need me to I can look at it after midnight tomorrow when all my classes are done. Since we don't have the tests completed yet, I'd like to run the demo applications with it quick. First glance it looks good though.

@daimajia
Copy link
Owner

daimajia commented May 1, 2015

@jpshelley great!

daimajia added a commit that referenced this pull request May 5, 2015
Refactor SwipeItemManager code to decouple it from adapter converns
@daimajia daimajia merged commit cc6a322 into daimajia:master May 5, 2015
@daimajia
Copy link
Owner

daimajia commented May 5, 2015

Thanks @mcumings ~

@mcumings
Copy link
Contributor Author

mcumings commented May 5, 2015

No problem! Thanks for publishing this library (and merging the PR)!

@daimajia
Copy link
Owner

daimajia commented May 6, 2015

@mcumings I really want to invite you to be a collaborator of this project, because you are really awesome, would you like be? :-D

@mcumings
Copy link
Contributor Author

mcumings commented May 6, 2015

I appreciate the offer but respectfully decline. :)

@daimajia
Copy link
Owner

daimajia commented May 6, 2015

@mcumings Respect your decision. 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants