Conversation
This gets a surprising amount of Nemeth generated correctly. It is not ready for someone to use though. Still much work to do: various indicators (numeric, punctuation, ...) need work modifiers (munder/mover) and enclosures are not implemented typeface changes (should add to unicode.yaml) tables Getting the indicators right is probably the hardest part. At some point, a useful speedup up for loading would be to split the Unicode tables (there are now one for speech and one for braille) into primary and secondary parts. The primary table would be the 300 - 500 chars that are most used and the secondary one the rest of the chars. Loading unicode.yaml takes about 50ms, and doing the split will take it down to under 10ms. Maybe just 5ms. With two tables to load, that could save 90ms on startup. A flag would need to be added to SpeechRules to indicate whether the secondary table was loaded and a check that if no match was found on lookup, it should load the secondary table. Added some basic tests for tags along with SRE tests. The SRE tests are dubious in many cases in that some are geared towards text (footnotes, etc) and also contain bugs. They need trimming. Probably should add a test for every rule that matters for math. The green book as about 200 rules, although many are not about math. On the other, many of the rules have subparts, so there might need to be 500 or so tests.
The tests from SRE (AataNemeth, SRE_Nemeth72, SRE_NemethBase) might have errors in them. Also, some of tests deal with text/math changes and are not really appropriate in translating MathML. These files need clean up. There is still much work to be done to get the tests to all work!
Added mixed fractions and munder, etc. Added lots more Unicode chars (from SRE), but they need work/vetting
…multiple operators in a row
Now using ASCII indicators for braille chars which get cleaned in a pass after the rules are run. Regenerated chars to make use of this and fixed up existing chars from MS. Added (commented out) a list of Nemeth functions to definitions.yaml to be used when I redo definitions.rs
Fix a character that was being overwritten by MS translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge in first attempt at Nemeth generation. Still plenty to do, but the results aren't too bad with this merge.