Update GUI with improved labels and load logo image#11
Merged
Conversation
This was referenced Mar 20, 2022
Closed
NSoiffer
requested changes
Mar 20, 2022
Collaborator
There was a problem hiding this comment.
Looks mostly good, but I see the line
import wx.xrc
is back. That will generate an error when run in NVDA needs to go away. I could a line or two to the build script to remove it or comment it out. Let me know.
Also, why change from point to github to
<property name="path">C:\Users\Rorme\OneDrive - DAISY Consortium\DAISY\Activities\Software tools\MathCAT\MathCATForPython\NVDA-addon\addon\globalPlugins\MathCAT</property>
Change path for code generation to relative
Comment import wx
Comment import wx.xrc
Member
Author
|
The import wx.xrc is generated by the wxFormBuilder tool. I don't see anything I can change to stop it from adding this, so I think a build script may be necessary to comment this or remove it. |
Collaborator
|
Fixes look good. I'll look into adding a line to the build script to deal with the import (I'll probably use 'sed') |
Member
Author
|
The surplus import statement is a known bug in wxFormBuilder
Error in Python creation code · Issue #171 · wxFormBuilder/wxFormBuilder (github.com)<wxFormBuilder/wxFormBuilder#171>
It was logged nearly 10 years ago, so I think your fix in the build script may be the fastest approach 😉
|
Collaborator
|
Ok. Since it is working, leaving it is faster than fixing it ;-)
I have a request for another item for the dialog: "Say 'cap' for math
speech" followed by a checkbox. The chemistry group feels this is
important. But don't add it quite yet. I just added a checkbox to the
MathCATDemo page (probably will show up Thursday your time) along with an
automatic pitch change for caps so they can test out what pitch change vs
"cap" is like.
Neil
…On Tue, Oct 11, 2022 at 1:53 AM Richard Orme ***@***.***> wrote:
The surplus import statement is a known bug in wxFormBuilder
Error in Python creation code · Issue #171 · wxFormBuilder/wxFormBuilder (
github.com)<wxFormBuilder/wxFormBuilder#171>
It was logged nearly 10 years ago, so I think your fix in the build script
may be the fastest approach 😉
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALZM3CQN35I72XFRUCGX23WCUTJZANCNFSM5RF4I73A>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logo image is now loaded from within MathCATPreferences, so MathCATGUI is untouched after it is generated from wxFormBuilder.
Changed the label of the speech rate option, and changed the logo of the braille highlight option.