Conversation
Add language names to list box based on the language codes derived from the folder names.
Collaborator
|
I think it is better to just define the languages as list directly. I've linked a file with the definition in it to make your life easier. I don't know github well enough to know how to modify your PR myself, so I'm afraid I pushing this back to you... |
Member
Author
|
Please check if you are happy to merge this now. |
Collaborator
|
Looks good. I probably would have just made the table global rather than have a function that returns it, but what you have is fine. |
Collaborator
|
I merged it in. Your code is working, but MathCAT seems to be stuck on
English in NVDA (changing languages works fine stand-alone). We might need
to add a "User Preference" option where the language used matches the
language NVDA is set to use (we'll make up a code like "default" that can't
match anything but has a nice display "User Preference (default)" . Don't
make a change until I figure this out though. I'm off to get some exercise
while the rain (and wind) have stopped, so you probably won't hear from me
until tomorrow your time.
Neil
…On Wed, Dec 28, 2022 at 12:39 PM Richard Orme ***@***.***> wrote:
Please check if you are happy to merge this now.
—
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALZM3FMLNINUULBCNXDZYTWPSQQDANCNFSM6AAAAAATKTSBNI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add language names to list box based on the language codes derived from the folder names.