Conversation
…tests All 14 conditional tests and all 9 operator tests in Rust were full-pipeline integration tests (parse → install → propagate → type check) that duplicate coverage already provided by Ruby integration tests in conditional_test.rb and operator_test.rb. Remove these redundant Rust tests and add 3 UNIQUE scenarios that previously existed only in Rust: - nested conditionals union type (conditional_test.rb) - nested logical operators union type (operator_test.rb) - !nil returns boolean (operator_test.rb) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dak2
force-pushed
the
migrate-conditionals-operators-tests-to-ruby
branch
from
28d7fb2 to
77460f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
These Rust tests were full-pipeline integration tests (
parse → install → propagate → type check) that verify the same type inference results already covered byconditional_test.rbandoperator_test.rb. Rust tests should focus on internal state verification (scope management, variable binding, edge propagation) that cannot be tested end-to-end, while Ruby integration tests cover type inference outcomes.Changes
conditionals.rsand all 9 fromoperators.rstest_nested_conditionals_union_type(conditional_test.rb)test_nested_logical_operators_union_type(operator_test.rb)test_not_nil_returns_boolean(operator_test.rb)Checked
cd core && cargo test --lib— 292 passedbundle exec rake test— 240 passed, 0 failures🤖 Generated with Claude Code