Conversation
… Rust to Ruby The Rust analyzer tests for these domains were full-pipeline integration tests (parse → install → propagate → resolve) that duplicate the Ruby integration tests. Move unique scenarios to Ruby and remove redundant Rust tests, keeping only true unit tests that verify internal state not observable through the CLI. - definitions.rs: 20 → 12 tests (remove 8 redundant) - dispatch.rs: remove implicit self, constant read, keyword arg tests - parameters.rs: 11 → 3 tests (remove 8 redundant) - Add 2 implicit self call tests to Ruby (module, block) - Add 1 constant read test to Ruby (deeply nested) - Add 1 parameter test to Ruby (keyword arg via .new) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Rust analyzer tests for implicit self calls, constant reads, parameters, and definitions were full-pipeline integration tests (
parse → install → propagate → resolve) that duplicated Ruby integration tests. This migration removes redundant Rust tests and moves unique scenarios to Ruby, keeping only true unit tests that verify internal state not observable through the CLI.Changes
get_type_showhelperApi::V1::Userresolution).new→initialize)Checked
cd core && cargo test --lib— all passbundle exec rake test— all pass🤖 Generated with Claude Code