Merged
Conversation
dak2
force-pushed
the
migrate-implicit-self-constant-param-def-tests-to-ruby
branch
from
318f24e to
3918110
Compare
dak2
changed the title
After migrating integration-style tests from Rust to Ruby, several analyzer functions no longer need pub visibility since they are only used within the crate. Restricting to pub(crate) enforces proper encapsulation and prevents unintended external usage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dak2
force-pushed
the
migrate-implicit-self-constant-param-def-tests-to-ruby
branch
from
3918110 to
e2e8785
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the test strategy rethink, integration-style tests for implicit self calls, constant resolution, parameters, and definitions have been migrated from Rust to Ruby. After this migration, several analyzer functions that were previously
pub(to be accessible from removed Rust tests) no longer need public visibility since they are only called within the crate.Changes
calls.rs,dispatch.rs,parameters.rs, andvariables.rsfrompubtopub(crate)AttrKind,DispatchResult,NeedsChildKind,MixinKindalso narrowed topub(crate)Checked
cd core && cargo test --lib— all tests pass🤖 Generated with Claude Code