Remove redundant literals and parentheses Rust tests#77
Merged
Conversation
2 tasks
dak2
force-pushed
the
remove-redundant-literals-parentheses-tests
branch
2 times, most recently
from
ff4b042 to
b9e0179
Compare
These Rust tests duplicate what Ruby integration tests already cover. Consolidating into Ruby tests keeps a single source of truth.
dak2
force-pushed
the
remove-redundant-literals-parentheses-tests
branch
from
b9e0179 to
a4dbd52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
These Rust tests duplicate what Ruby integration tests already cover. Consolidating into Ruby keeps a single source of truth.
Changes
literals.rs(7 tests) andparentheses.rs(3 tests)test_parenthesized_multiple_statementsto RubyChecked
cd core && cargo test --lib— all passbundle exec rake test— all pass