Conversation
hiohiohio
reviewed
Jul 30, 2022
| @@ -1,4 +1,5 @@ | |||
| # jquants-api-client | |||
| [](https://badge.fury.io/py/jquants-api-client-python) | |||
There was a problem hiding this comment.
ライブラリ名変わってしまいすみません！
markdownlint の MD022 に従って、1行入れています。
https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md022---headings-should-be-surrounded-by-blank-lines
Suggested change
| [](https://badge.fury.io/py/jquants-api-client-python) | |
| [](https://badge.fury.io/py/jquants-api-client) |
hiohiohio
reviewed
Jul 30, 2022
| fail-fast: true | ||
| matrix: | ||
| os: [ "ubuntu-latest" ] | ||
| python-version: [ "3.7", "3.8", "3.9", "3.10" ] |
There was a problem hiding this comment.
3.11 のベータ版がでているので、念の為にテストスコープに入れておきたいです！
Suggested change
| python-version: [ "3.7", "3.8", "3.9", "3.10" ] | |
| python-version: [ "3.7", "3.8", "3.9", "3.10", "3.11-dev" ] |
hiohiohio
reviewed
Jul 30, 2022
Comment on lines
+91
to
+92
| pytest tests/ | ||
| coverage report |
There was a problem hiding this comment.
pytest-cov を使っても良いのかなとおもいました！
https://pytest-cov.readthedocs.io/en/latest/readme.html#usage
Suggested change
| pytest tests/ | |
| coverage report | |
| poetry run pytest --cov=./jquants-api-client-python --cov-report=xml tests/ |
hiohiohio
reviewed
Jul 31, 2022
Co-authored-by: hiohiohio <hiohiohio@users.noreply.github.com>
# Conflicts: # pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.