Adopt useful changes from kiennq/ghostel fork#103
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Cherry-picks two improvements from the kiennq/ghostel fork to better align cursor behavior with editor preferences and to improve native module auto-download compatibility across platform naming differences.
Changes:
- Added
ghostel-ignore-cursor-changedefcustom to ignore terminal-driven cursor shape/visibility changes (while copy mode continues to manage cursor state). - Normalized platform arch strings in
ghostel--module-platform-tag(amd64→x86_64,arm64→aarch64) to match release asset naming.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dakra
force-pushed
the
fork/adopt-kiennq-improvements
branch
from
994c238 to
4e8269e
Compare
When non-nil, terminal requests to change cursor shape or visibility are ignored. Useful when editor-owned cursor behavior should take precedence. Copy mode always forces a visible cursor regardless. Inspired by kiennq/ghostel fork.
Some systems report "amd64" or "arm64" in system-configuration instead of the Zig target triple names "x86_64" / "aarch64" used in release asset filenames. Normalize before building the tag so auto-download works on those systems. Inspired by kiennq/ghostel fork.
dakra
force-pushed
the
fork/adopt-kiennq-improvements
branch
from
4e8269e to
27dcec0
Compare
Owner
Author
|
@kiennq jFYI, I looked at what other changes besides the dynloader and windows support you have in your fork. I implemented the 2 that where imho useful. I also tried the face caching but that only saved 1ns but adds to local defvars, so imho the state + extra code( / if branch) is not worth that nanosecond. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks two useful improvements from the kiennq/ghostel fork, skipping Windows ConPTY, dyn-loader, and changes that conflict with our architecture.
ghostel-ignore-cursor-changedefcustom: When non-nil, terminal requests to change cursor shape/visibility are ignored. Useful when editor-owned cursor behavior should take precedence.amd64->x86_64andarm64->aarch64inghostel--module-platform-tagso module auto-download works on systems wheresystem-configurationuses non-Zig arch names.Changes reviewed and skipped
ghostel--scroll,ghostel--scroll-top)pixel-scroll-precision-modesuppressioninhibit-read-onlyapproach is more Emacs-conventionalghostel-cursor-followTest plan
make -j4 allpasses (66/66 tests)ghostel-ignore-cursor-changeblocks cursor shape changes when set to tghostel--module-platform-tagreturns correct tag on ARM systems