Enforce strict error handling in Zig native module#252
Merged
Conversation
Replace swallowed errors (bare `catch {}`) with explicit logging to
the Emacs `*Messages*` buffer using `env.logErrorf()` and
`env.signalErrorf()`. This aligns the codebase with the guidelines in
`src/AGENTS.md` and improves observability for failures in color
configuration, PWD updates, and render state management.
Standardize logging messages to the `ghostel: [function] failed:
[error]` pattern.
> Written by Gemini, lightly audited by me.
mgeisler
force-pushed
the
zig-error-handling
branch
from
fffa79f to
2a0fb79
Compare
Collaborator
|
I'm planning a bit of an overhaul of this aspect of the Zig code but this is a step in the right direction so I will merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace swallowed errors (bare
catch {}) with explicit logging to the Emacs*Messages*buffer usingenv.logErrorf()andenv.signalErrorf(). This aligns the codebase with the guidelines insrc/AGENTS.mdand improves observability for failures in color configuration, PWD updates, and render state management.Standardize logging messages to the
ghostel: [function] failed: [error]pattern.