More ergonomic Zig/Emacs API#260
Merged
Merged
Conversation
Takes variable number of arguments and automatically converts them.
Collaborator
Author
|
@claude Check it out |
Owner
|
@claude review |
|
Claude finished @dakra's task in 4m 14s —— View job ReviewNice cleanup — the variadic Findings (one bug, two nits) posted as inline comments:
No concerns on the |
The categorization stopped making sense to alphabetical sort is better in the long run.
7e9c990 to
047a600
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
call0/call1/... withenv.f("func-name", .{args})— a single variadic call that auto-converts Zig types to Emacs valuessignalError/logErrorto take format args directly; both auto-prependghostel:and use Emacs format syntax (%s)env.set,env.symbolValue,env.list,env.consbindFunctiondocstrings to multiline string literals for readabilityTest plan
zig buildpasses