Fix flickering when exiting copy mode#270
Merged
Merged
Conversation
When exiting read-only modes (like copy mode or Emacs mode), the viewport is snapped back to the live terminal cursor, which involves jumping point to the end of the buffer. Previously, this process scheduled an asynchronous delayed redraw. During the delay before the timer fired, control returned to the Emacs redisplay engine. Emacs would observe point at `point-max` and attempt to violently recenter the window around it. Once the `ghostel--delayed-redraw` timer finally fired a few milliseconds later, it would calculate the true active area (the `viewport-start`) and anchor the window back into place, resulting in a visible and jarring flicker. This commit adds a synchronous call to `ghostel-force-redraw` at the end of the read-only exit sequence. By forcing the redraw immediately, the window is correctly anchored to the terminal's active viewport before Emacs has a chance to perform an unanchored redisplay cycle. Fixes dakra#269.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exiting read-only modes (like copy mode or Emacs mode), the viewport is snapped back to the live terminal cursor, which involves jumping point to the end of the buffer. Previously, this process scheduled an asynchronous delayed redraw.
During the delay before the timer fired, control returned to the Emacs redisplay engine. Emacs would observe point at
point-maxand attempt to violently recenter the window around it. Once theghostel--delayed-redrawtimer finally fired a few milliseconds later, it would calculate the true active area (theviewport-start) and anchor the window back into place, resulting in a visible and jarring flicker.This commit adds a synchronous call to
ghostel-force-redrawat the end of the read-only exit sequence. By forcing the redraw immediately, the window is correctly anchored to the terminal's active viewport before Emacs has a chance to perform an unanchored redisplay cycle.Fixes #269.